Closed henryiii closed 1 year ago
Hi. Give me until early next week to look into this as it seems to be a lot. Worth emailing the gang as it affects everyone, I guess ...
If I understand a lot will be removed and redirected. So we loose "control" over a lot of development tips. Is that correct? Do we have any contribution to "Scientific-Python Development Pages / cookie / repo-review"?
Since we can be as involved in scientific-python.org as we want, we still do have the opportunity to control what's in these pages. But it's true that we're now sharing the responsibility with a larger group.
And quite correct about emailing the full group, I've got about 1/3 of an email drafted already and hopefully will have a chance to finish it soon. Edit: finished and sent, also pasted most of it into the issue description above.
FYI, https://github.com/scikit-hep/scikit-hep.github.io/pull/344 caused conflicts that I now have to spend time undoing. Any progress on getting signoffs/reviews of this?
scientific-python/cookie has added more features in the meantime:
And more: https://github.com/scientific-python/cookie/releases/tag/2023.07.06
Reminder I'm happy to request anyone interested to be added to the scientific-python/cookie repo. Or repo-review.
Sorry for that! It seemed benign. People are really busy with commission and stuff. Please give it a couple more days, not that much for such a big change. I will try and look asap; now is rather late here.
Please take your time, as long as there's progress and this doesn't keep slipping back and getting merge conflicts! :)
One of the main questions I think you'll want to review is, should the pages show up in the sidebar still? I've put them there for now, but maybe it would be better not to have side bar links go to somewhere else. I can remove them from the sidebar while still keeping the page redirects (so links continue to work) if that's better. We can also keep the links in the sidebar for now, and remove them later. Current version:
Hello @henryiii, first off, a big 🎩 for this huge and impressive amount of work. I hope the folks at Scientific Python appreciated the contribution!
The move is effectively done at this point, as we would probably be having a less maintained version here, would we not make the move you suggest. But your suggestion does make sense. It is just about the best way to engage with Scientific Python, actually, so I agree with you and @jpivarski that the move is the way to go.
To be seen how things evolve but at this point in time I quite like the fact that you left the menu but swapped content for the relevant links. I also find it nice that I read above about the move of the site to Scientific Python. If on their side there is a little sentence saying the thing came from Scikit-HEP, that's also a fair thing IMO.
So 👍 on this!
If on their side there is a little sentence saying the thing came from Scikit-HEP, that's also a fair thing IMO.
Added at https://github.com/scientific-python/cookie/pull/219.
@henryiii, just checking the site the (redirect) links at https://scikit-hep.org/developer do not seem to be there? At least I do not see how to get to Scientific Python for the various links/pages.
Ahh, must not be an allowed plugin for the integrated GH Pages build. I can update this tonight to use a proper GHA builder.
Should work now with #347.
Yep. I have 2 suggestions:
Link checker is hard, there are 314 failures, including a lot of indico timeouts and such. https://scikit-hep.org/pylhe/
isn't a real page. Also not seeing https://davidyakobovitch.github.io/2019-04-01_fnal/.
This moves to using the Scientific-Python Development Pages / cookie / repo-review. Pages that moved there redirect (links or menu items) and menu items have link icons.
I spent most of my time at the First Scientific Python Developers Summit working on moving the Scikit-HEP developer pages into Scientific Python and merging with with the NSLS-II guide. The finished result is visible at learn.scientific-python.org/development. A live version (the final version gets updated on tags) is available at scientific-python-cookie.readthedocs.io.
A lot of work has gone into this, here are the highlights that have been added or changed in the last month during and since the summit:
I’ve also done something I’ve wanted to do for a long time: the guide, the cookie-cutter, and the checks are all in a single repo! The repo is https://github.com/scientific-python/cookie, which is the moved scikit-hep/cookie (the old URL for cookiecutter still works!). A lot of work went into the cookie cutter, too!
Along with this was probably the biggest change, one requested by several people at the summit: scientific-python/repo-review (was scikit-hep/repo-review) is now a completely general framework for implementing checks in Python 3.10+. The checks have been moved to `sp-repo-review, which is now part of scientific-python/cookie. There are too many changes to list here, so just the key ones in 0.6, 0.7 & 0.8:
The full changelog is at https://repo-review.readthedocs.io/en/latest/changelog.html - you can even see the 10 beta releases in-between 0.6.x and 0.7.0 where a lot of this refactoring work was happening. If you have configuration you’d like to write check for, feel free to write a plugin!
Finally, sp-repo-review contains the previous repo-review plugins with checks:
I’m also working with a fellow this year to provide an even better terminal experience. I’ll be adding more documentation on setting up compiled projects, as well. I’m hoping to work on better backend validation with repo-review, possibly by writing a plugin for pyproject-validate? We’ll see.