fix: restore the x in the header

scikit-hep / uproot-browser

A TUI viewer for ROOT files

BSD 3-Clause "New" or "Revised" License

70 stars 7 forks source link

fix: restore the x in the header #126

Closed henryiii closed 1 year ago

henryiii commented 1 year ago

We went back to the default header, but someone noticed it was missing. This restores the x. Closes #124. A ❓ could be added on the other side after #130. :)

matthewfeickert commented 1 year ago

@henryiii if this was intentional it is fine to leave it out. It just wasn't clear to me what the functionality of the circle in the upper left hand side was if it isn't supposed to be a close button. Can you clarify?

henryiii commented 1 year ago

It is the default visual flair for Textual. Doesn't have any use whatsoever. The entire header was clickable, but only to expand and shrink - I'm guessing just to show off textual & resizing.

Fine to add this, and with #130 we could add a ❓ too.

matthewfeickert commented 1 year ago

Excellent and thanks!