Lazy Cartesian Evaluation for pt/eta/phi/mass LorentzVectors

scikit-hep / uproot3-methods

Pythonic behaviors for non-I/O related ROOT classes.

BSD 3-Clause "New" or "Revised" License

21 stars 28 forks source link

Lazy Cartesian Evaluation for pt/eta/phi/mass LorentzVectors #37

Closed lgray closed 5 years ago

lgray commented 5 years ago

@jpivarski this is a prototype/work-in-progress implementation but I wanted to stick it here to see what you thought. Pardon the dust.

Presently I have to use a .to_cartesian() converter function when I need to do sums, but it's good enough for what I need to accomplish.

lgray commented 5 years ago

@jpivarski dust is now settled and a figured out my last typing issue. This PR is ready to go. I leave the caching in place so everything remains fast in all cases.

jpivarski commented 5 years ago

It all looks good, I understand the change to tests, and I also ran all of the uproot tests (including the awkward features notebook) with these changes. No problems, so let's go!