Use the JaggedArray type of the methods class passed in!

scikit-hep / uproot3-methods

Pythonic behaviors for non-I/O related ROOT classes.

BSD 3-Clause "New" or "Revised" License

21 stars 28 forks source link

Use the JaggedArray type of the methods class passed in! #38

Closed lgray closed 5 years ago

lgray commented 5 years ago

This preserves numba-ness and other JaggedArray subtypes by using the JaggedArray constructor passed to the mixin (which is always called "JaggedArray").

lgray commented 5 years ago

@jpivarski please take a look!

jpivarski commented 5 years ago

This looks good. I think the intention of cls.awkward.JaggedArray was to get the specific (i.e. Numbaed or Not) class, and somehow that didn't work. (Maybe cls isn't what I thought it was? I'm quite sure I didn't test it—this was one of many, many changes!) arrays[0].JaggedArray really must work.