Open chrisburr opened 5 years ago
Even though I recently simplified the way I'm presenting the license (all source files just have a URL pointing to the one at the top of the repo, rather than its full text), I haven't moved or changed the file named LICENSE. I wonder if setup.py changed how it creates source tarballs?
Maybe it is caused by the removal of setuptools_scm
from the environment that is used for deploying the tarballs? Else I'm not sure.
Oh, that sounds plausible. Even if so, we should wait for @reikdas to solve his problems with Travis before trying to fix that. The setuptools_scm
version was only a problem with Python 3.6 and we deploy from Python 3.7, so it could be reintroduced with a conditional. However, that complicates things and the problem with Travis is not yet solved.
Perhaps reintroducing setuptools_scm
renaming it to setuptools-scm
might fix the issue? That is how it is currently named in the uproot travis.yml (the name was changed in the file in the PR for the travis and appveyor fix in uproot). I think they recently renamed it considering that the PyPI setuptools-scm page https://pypi.org/project/setuptools-scm/ says the command to install it is pip install setuptools-scm
but refers to it as setuptools_scm
.
Testing this would probably need a new release (and further releases for each failed test), so I am a little cautious about sending a pull request with the above idea.
The licence file was included in the PyPI tarball for previous releases.