search

scikit-hep / uproot3-methods

Pythonic behaviors for non-I/O related ROOT classes.
BSD 3-Clause "New" or "Revised" License
21 stars 28 forks source link

from_ptetaphi() should be from_ptetaphie() #69

Closed masonproffitt closed 4 years ago

masonproffitt commented 4 years ago

TLorentzVector.from_ptetaphi()'s signature is actually pt, eta, phi, energy. There's from_ptetaphim() for pt, eta, phi, mass, so one would expect the "e" to be in the first function's name. This would be more consistent with ROOT's TLorentzVector. Can we just add from_ptetaphie() as a synonym?

jpivarski commented 4 years ago

Yes. :)

masonproffitt commented 4 years ago

Added by #70.