Closed dntaylor closed 4 years ago
It looks like these were bugs that got through due to insufficient testing.
It surprises me that p3
is a tuple—I would have thought it was a TVector3
. I'm going to take a closer look to be sure it's always a tuple.
Thanks for adding these tests and correcting it!
Oh, yeah, it is. The name p3
is used in other contexts as a TVector3
, but the output of the rotation methods are tuples.
This fixes an issue with the current version of rotate_axis (and similar methods) of TLorentzVector. Currently the master will throw an error with the conversion of the tuple returned by TVector3 into the appropriate TLorentzVector type. I've also added some unit tests for rotation.
You can test the results with
The output of which should be