search

scikit-hep / uproot3-methods

Pythonic behaviors for non-I/O related ROOT classes.
BSD 3-Clause "New" or "Revised" License
21 stars 28 forks source link

Add support for Python 3.8 and 3.9 #90

Closed eduardo-rodrigues closed 4 years ago

eduardo-rodrigues commented 4 years ago

While at it, add some tests on Python 3.8, which were missing.

To minimise the amount of tests I dropped them on 3.6. That seems OK at this stage.

Let me know if you fancy more tests.

eduardo-rodrigues commented 4 years ago

Not too surprising (I had not checked all dependencies) but numpy==1.13 is a no-go for Python 3.9. I reckon you could very well require >=1.15, but let me know.

eduardo-rodrigues commented 4 years ago

uproot-methods is part of the Awkward 0/Uproot 3 system, which is being deprecated and will be non-default by December 1, but that's not reason to include this test.

Right. Better still support uproot 3 & awkward-array for a while, as many will not switch immediately. That's why I think it makes sense to support Python 3.9; and 3.8 as well, BTW.

eduardo-rodrigues commented 4 years ago

OK, this is ready modulo a bump in the version towards a patch release. I will wait for your green light to commit the update to version.py ...

Once this is done I can make the necessary updates to uproot and awkward-array.

jpivarski commented 4 years ago

Please do update the version number (a new minor version, the "y" in "x.y.z"). I don't think there will be any issues with Awkward 0 and Uproot 3, apart from NumPy version. Given that this doesn't have long to live, we can be merciless in removing things that don't work.

eduardo-rodrigues commented 4 years ago

Done bumping up to 0.8.0, @jpivarski.

eduardo-rodrigues commented 4 years ago

Kindly make the release when you find the time ... Thanks.

jpivarski commented 4 years ago

Right—the release, too—that's a little harder to do from my phone. Let me see...