search

scikit-hep / uproot3

ROOT I/O in pure Python and NumPy.
BSD 3-Clause "New" or "Revised" License
314 stars 67 forks source link

Support boost_histogram 0.10.0 #512

Closed henryiii closed 4 years ago

henryiii commented 4 years ago

In https://github.com/scikit-hep/boost-histogram/issues/410, @HDembinski requested that I add an underscore to sum_of_weighted_deltas_squared, and this has broken Uproot's to_boost() method on TProfiles.

Now when reading a TProfile, we get the error:

AttributeError                            Traceback (most recent call last)
<ipython-input-10-d946cc02fe81> in <module>
----> 1 mplhep.histplot(rfile['hprof;1'].to_boost())

/usr/local/Caskroom/miniconda/base/envs/bh-talk/lib/python3.8/site-packages/uproot4/behaviors/TProfile.py in to_boost(self)
    178         view.sum_of_weights_squared
    179         view.value = values
--> 180         view.sum_of_weighted_deltas_squared
    181 
    182         raise NotImplementedError(repr(self))

AttributeError: 'WeightedMeanView' object has no attribute 'sum_of_weighted_deltas_squared'
henryiii commented 4 years ago

(This was supposed to be on Uproot4)...