scikit-hep / vector

Vector classes and utilities
https://vector.readthedocs.io
BSD 3-Clause "New" or "Revised" License
80 stars 27 forks source link

Remember to implement arrays of 2D/3D/Lorentz vectors in Numba #43

Open jpivarski opened 3 years ago

jpivarski commented 3 years ago

PR #42 had to stop early because we need Numba to let us recognize np.ndarray subclasses inside of a Numba-compiled function. This feature is being implemented, but it is not finished or in any released version of Numba yet: numba/numba#6148.

When that is done, we can follow the procedure described in https://github.com/numba/numba/pull/6148#issuecomment-676541700 to:

That's it! Not nearly as much work as vector.backends.numba_object.

henryiii commented 3 years ago

https://github.com/scikit-hep/vector/blob/1c4b81d5f05f5c91b01f3440a2e5fc5ba867493f/src/vector/_backends/numba_numpy.py#L11

This PR was supplanted by https://github.com/numba/numba/pull/7121, which was added in Numba 0.54, so this should be unblocked.