Closed Saransh-cpp closed 3 weeks ago
Attention: Patch coverage is 90.90909%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 82.79%. Comparing base (
23f1c42
) to head (af9000a
).
Files | Patch % | Lines |
---|---|---|
src/vector/__init__.py | 50.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks for the review! That makes sense, I'll create a new branch before merging the PR. I think I'll hold this till coffea migrates to vector as the process has already changed several things in vector.
Now that coffea has switched to vector and the changes are up in a release, it should be okay to merge this in. I will wait for a couple of weeks before merging this, just in case we get some suggestions from coffee users. I think pyhep.dev would be the perfect place to merge this in and create a new release.
Description
Kindly take a look at CONTRIBUTING.md.
Please describe the purpose of this pull request. Reference and link to any relevant issues or pull requests.
Checklist
$ pre-commit run --all-files
or$ nox -s lint
)$ pytest
or$ nox -s tests
)$ cd docs; make clean; make html
or$ nox -s docs
)$ pytest --doctest-plus src/vector/
or$ nox -s doctests
)Before Merging