scikit-hep / vector

Vector classes and utilities
https://vector.readthedocs.io
BSD 3-Clause "New" or "Revised" License
77 stars 24 forks source link

Drop support for awkward v1 #434

Closed Saransh-cpp closed 3 weeks ago

Saransh-cpp commented 6 months ago

Description

Kindly take a look at CONTRIBUTING.md.

Please describe the purpose of this pull request. Reference and link to any relevant issues or pull requests.

Checklist

Before Merging

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 90.90909% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 82.79%. Comparing base (23f1c42) to head (af9000a).

Files Patch % Lines
src/vector/__init__.py 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #434 +/- ## ========================================== + Coverage 82.77% 82.79% +0.02% ========================================== Files 96 96 Lines 11583 11575 -8 ========================================== - Hits 9588 9584 -4 + Misses 1995 1991 -4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Saransh-cpp commented 6 months ago

Thanks for the review! That makes sense, I'll create a new branch before merging the PR. I think I'll hold this till coffea migrates to vector as the process has already changed several things in vector.

Saransh-cpp commented 1 month ago

Now that coffea has switched to vector and the changes are up in a release, it should be okay to merge this in. I will wait for a couple of weeks before merging this, just in case we get some suggestions from coffee users. I think pyhep.dev would be the perfect place to merge this in and create a new release.