scikit-image / skimage-sandbox

Server for executing remote snippets (used in examples gallery)
1 stars 4 forks source link

Add multiple image support #3

Closed sharky93 closed 10 years ago

sharky93 commented 10 years ago

Montage / a slider?

Probably does not make much sense if we go for explicit / inplace integration, on the docs page itself.

stefanv commented 10 years ago

I'd just put them next to one another (slides if needs be)

ahojnnes commented 10 years ago

I'd put the output below the code text form, and put them one below the other...

sharky93 commented 10 years ago

@ahojnnes initially we have an image comparison and then code below it - http://198.206.133.45:5000/code

how should we change that if we go for one below the other?

ahojnnes commented 10 years ago

I would keep the side by side view, but push the code to the top.

Then, if an example has multiple output images, just put one below the other in the respective columns (original, output)... ?

sharky93 commented 10 years ago

@ahojnnes Hmm, makes sense. Any ideas on how to proceed with this in the explicit integration way?

ahojnnes commented 10 years ago

Let’s wait for Stefan’s feedback.

stefanv commented 10 years ago

The way I see it you want the user to be able to edit an existing snippet on the examples page, click a button to execute, and get the current result replaced. If the user chooses to add more plots/images, then those can be displayed as well (one below the other, e.g., as @ahojnnes suggests).

sharky93 commented 10 years ago

@stefanv @ahojnnes Since there is no way of knowing which image to replace. Say there are 3 images on an example page currently, and the code which the user generates 3 too, what I think we should do is, just replace them one by one in order. If the code generates more, put more after the last one. Makes sense?

sharky93 commented 10 years ago

Replaces already existing images only - https://github.com/sharky93/scikit-image/commit/6d5e1eba4d9db512c2795677422fa02e355468ed Adds images to the page if more are generated by the code - https://github.com/sharky93/scikit-image/commit/2064bbf76c8356b9df64d179d8eafea7c97bdde8