Closed derekahuang closed 1 year ago
@derekahuang Hello,
I've checked the PR today and it looks good. Just found some small pep8 formatting warnings that I already fixed. So I'm merging the PR.
It would be interesting to update the DS methods that use diversity information (DESKNN and DESClustering) to use the new vectorized functions in another PR now that they are available. Do you think you could contribute to that as well?
@Menelau thanks for merging. and yes i can take a look at updating those methods with the new vectorized function
Opening this PR in response to issue #272
This PR vectorizes
diversity.py
into a new filediversity_batch.py
. All the diversity functions now accept inputs of the form