scikit-learn-contrib / MAPIE

A scikit-learn-compatible module to estimate prediction intervals and control risks based on conformal predictions.
https://mapie.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
1.27k stars 102 forks source link

ENH: move get_true_label_position to utils in classification #427

Closed BaptisteCalot closed 4 months ago

BaptisteCalot commented 5 months ago

Description

1- Move get_true_label_position function from classification.py to a new utils file 2- Add a test for this function

How Has This Been Tested?

1- Check if the return of my function is correct 2- Check if the shape of my function's return is correct

LacombeLouis commented 4 months ago

Hey @BaptisteCalot, Thank you for this PR! For the moment it doesn't pass some tests, but we have fixed the issue. So you can git merge upstream/main and everything should work! Thank you!