numpy type aliases replaced by builtin types

scikit-learn-contrib / boruta_py

Python implementations of the Boruta all-relevant feature selection method.

BSD 3-Clause "New" or "Revised" License

1.46k stars 252 forks source link

numpy type aliases replaced by builtin types #102

Closed simontamayo closed 2 years ago

simontamayo commented 2 years ago

Dear devs, This PR addresses the issue that I posted here: https://github.com/scikit-learn-contrib/boruta_py/issues/101 Implemented changes include:

replacing np.float by float
replacing np.bool by bool
replacing np.int by int

danielhomola commented 2 years ago

Thanks for this!

EmmaTomps commented 1 year ago

This may be a stupid question, but has this change been reflected when downloading the package from pip? I still get the error AttributeError: module 'numpy' has no attribute 'int'. Says I am using versions 0.3

3zhang commented 1 year ago

This may be a stupid question, but has this change been reflected when downloading the package from pip? I still get the error AttributeError: module 'numpy' has no attribute 'int'. Says I am using versions 0.3

The package on pypi is three years old. So I don't think so.

rodrigc commented 3 months ago

This GitHub Action pushes new versions of the package to PyPi: https://github.com/scikit-learn-contrib/boruta_py/blob/master/.github/workflows/publish-to-pypi.yml

In order to trigger this GHA, a new release tag needs to be pushed to this repository. See discussion here: https://github.com/scikit-learn-contrib/boruta_py/issues/111