scikit-learn-contrib / boruta_py

Python implementations of the Boruta all-relevant feature selection method.
BSD 3-Clause "New" or "Revised" License
1.46k stars 252 forks source link

TypeError: BorutaPy.__init__() got an unexpected keyword argument 'early_stopping' #115

Open arilwan opened 1 year ago

arilwan commented 1 year ago

Looks like the early_stopping parameter wasn't used.

    def __init__(self, estimator, n_estimators=1000, perc=100, alpha=0.05,
                 two_step=True, max_iter=100, random_state=None, verbose=0,
                 early_stopping=False, n_iter_no_change=20):
        self.estimator = estimator
        self.n_estimators = n_estimators
        self.perc = perc
        self.alpha = alpha
        self.two_step = two_step
        self.max_iter = max_iter
        self.random_state = random_state
        self.verbose = verbose
        self.early_stopping = early_stopping
        self.n_iter_no_change = n_iter_no_change
        self.__version__ = '0.3'
        self._is_lightgbm = 'lightgbm' in str(type(self.estimator))

Same applies to n_iter_no_change.

Nimmerfall commented 11 months ago

It should be used as it appears here -> https://github.com/scikit-learn-contrib/boruta_py/blob/f783995eac12442af0c2b288368ae0802d4bea51/boruta/boruta_py.py#L370