support_weak_ and ranking_ for tentative features do not coincide

scikit-learn-contrib / boruta_py

Python implementations of the Boruta all-relevant feature selection method.

BSD 3-Clause "New" or "Revised" License

1.46k stars 252 forks source link

support_weak_ and ranking_ for tentative features do not coincide #73

Open Naehil opened 4 years ago

Naehil commented 4 years ago

If a tentative feature is rejected in the last iteration, the support_weak_ mask is adapted correctly, however, the ranking_ array isn't updated so that the rank of the rejected feature is still 2