Version requirements for Python and Dependencies - Githubissues

scikit-learn-contrib / category_encoders

A library of sklearn compatible categorical variable encoders

http://contrib.scikit-learn.org/category_encoders/

BSD 3-Clause "New" or "Revised" License

2.4k stars 393 forks source link

Version requirements for Python and Dependencies #359

Closed PaulWestenthanner closed 2 years ago

PaulWestenthanner commented 2 years ago

Expected Behavior

The versions specified in requirement.txt and the python versions should work.

Actual Behavior

Installing pandas >= 1.0 does not work on python 3.5
Installing sklearn >= 1.0 does not work with python 3.5 and 3.6
Unit tests fail for pandas < 0.23 although stated otherwise
There is a bug that makes numpy >1.20 incompatible with pandas <1.0.5 (c.f. https://github.com/numpy/numpy/issues/18355#issuecomment-774610226 and https://github.com/pandas-dev/pandas/issues/39520)

Proposed solution

Drop support for python 3.5
Also python 3.6 has reached end of life and should no longer be supported
Introduce a tox.ini file to easier check for compatible versions in the future
Introduce python >=3.7 specific features like f-strings and type hints