metadata tweaks for datasets in sdists

[bollwyvl]

Fixes https://github.com/conda-forge/category_encoders-feedstock/pull/21

Proposed Changes

• [x] include category_encoders.datasets in find_packages
• [x] add dataset csv to MANIFEST.in
• [x] source version from __init__.py instead of by import
• [x] fix a typo

[PaulWestenthanner]

@bollwyvl Thanks for submitting this PR. Do I see this correctly that v 2.5.1 is broken in conda? should I just merge this and release it as 2.5.2 or would conda need a re-release of 2.5.1?

[bollwyvl]

As a datasets is a brand new, non-critical feature, I don't think 2.5.1 is broken such that it would need to be yanked.

On Thu, Oct 6, 2022, 04:48 PaulWestenthanner @.***> wrote:

Thanks for submitting this PR. Do I see this correctly that v 2.5.1 is broken in conda?

Just the pypi sdist is broken, which won't affect most normal users. I haven't figured out how to fix 2.5.1 for conda.

should I just merge this and release it as 2.5.2

As a packaging-only change, "2.5.1.post0" might be the most "normal":

https://peps.python.org/pep-0440/#post-release-separators

or would conda need a re-release of 2.5.1?

I'll just wait!

— Reply to this email directly, view it on GitHub https://github.com/scikit-learn-contrib/category_encoders/pull/375#issuecomment-1269708109, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAALCRD44FBR3BDV5H7A6VDWB2OAJANCNFSM6AAAAAAQ54GGZY . You are receiving this because you authored the thread.Message ID: @.***>

[PaulWestenthanner]

Thanks for pointing this out, I've released version 2.5.1.post0

[bollwyvl]

Thanks for the speedy review! conda-forge build should be up within the hour.