search

scikit-learn-contrib / forest-confidence-interval

Confidence intervals for scikit-learn forest algorithms
http://contrib.scikit-learn.org/forest-confidence-interval/
MIT License
282 stars 48 forks source link

JOSS Review "License" [Blocker] #27

Closed DannyArends closed 7 years ago

DannyArends commented 7 years ago

LICENCE file is not an OSI approved licence

kpolimis commented 7 years ago

license changed to : MIT open source license

arokem commented 7 years ago

Addressed in https://github.com/scikit-learn-contrib/forest-confidence-interval/commit/61abf19f0a4f49a0fe23a27ef4d6d00192f53e06

DannyArends commented 7 years ago

The the license provided is still NOT the official MIT license, as provided by the open source foundation at https://opensource.org/licenses/MIT

The words: "All rights reserved." do NOT occur in the MIT license, and should be removed. The first line should read, (remove the (c), the comma (,) and please add the affiliation to the first line):

Copyright 2016 Ariel Rokem, Bryna Hazelton, Kivan Polimis (The University of Washington, eScience Institute)

When you want to use the MIT license, please copy the license verbatim from: https://opensource.org/licenses/MIT

arokem commented 7 years ago

Sorry about that. How's that? #53