scikit-learn-contrib / hdbscan

A high performance implementation of HDBSCAN clustering.
http://hdbscan.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
2.81k stars 507 forks source link

Unneeded `cython` `*import`s in `dist_metrics.pxd` #653

Open jakirkham opened 3 months ago

jakirkham commented 3 months ago

It looks like cython is both cimported and imported in dist_metrics.pxd (only the former is needed with cython unless pure Python mode is used)

https://github.com/scikit-learn-contrib/hdbscan/blob/2e7112d3b8a65ebb94db95c24243d0c79ad8cfa5/hdbscan/dist_metrics.pxd#L6-L7

However looking at the module it doesn't appear the cython namespace is used anywhere. So maybe both of these can be dropped?