search

scikit-learn-contrib / hiclass

A python library for hierarchical classification compatible with scikit-learn
BSD 3-Clause "New" or "Revised" License
113 stars 20 forks source link

Added "shap" and "xarray" packages as optional dependencies #107

Closed ashishpatel16 closed 6 months ago

ashishpatel16 commented 6 months ago

Hi @mirand863, this PR aims to -

Although, I have added extra dependencies in pipfile as well, the only place for adding "abstract dependencies" is the setup.py file source.

The pipfile dependencies still remain optional and can be installed during development if needed.

codecov-commenter commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (0f9f955) 98.40% compared to head (0f68354) 96.86%. Report is 4 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #107 +/- ## ========================================== - Coverage 98.40% 96.86% -1.55% ========================================== Files 8 11 +3 Lines 566 1086 +520 ========================================== + Hits 557 1052 +495 - Misses 9 34 +25 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mirand863 commented 6 months ago

@ashishpatel16 looks good to me. Will just test if it works once published on pypi. I could only get it to install locally with pip install -e ".[xai]"