scikit-learn-contrib / hiclass

A python library for hierarchical classification compatible with scikit-learn
BSD 3-Clause "New" or "Revised" License
113 stars 20 forks source link

Explainer implementation for LCPN #minor #108

Closed ashishpatel16 closed 5 months ago

ashishpatel16 commented 6 months ago

This PR aims to add the implementation for LCPN explainer. The major changes in the code are as follows -

codecov-commenter commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.87%. Comparing base (4595264) to head (5aa9998).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #108 +/- ## ========================================== + Coverage 96.68% 96.87% +0.18% ========================================== Files 13 13 Lines 1268 1280 +12 ========================================== + Hits 1226 1240 +14 + Misses 42 40 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ashishpatel16 commented 5 months ago

Hi @mirand863, this is the final version of the Explainer API for LCPN and LCPPN models. LCPL will follow soon.

The changes made here are as follows -

I'm looking forward to your remarks. Hoping this will be the finally merged!

ashishpatel16 commented 5 months ago

Hi @mirand863, I have incorporated the following changes -

ashishpatel16 commented 5 months ago

Hi, @mirand863, Updated changes in this PR are as follows -

mirand863 commented 5 months ago

Hi @ashishpatel16

The colabs notebook does not work unless I update the git checkout to git checkout --track origin/lcpn_explainer Can you please update it?

ashishpatel16 commented 5 months ago

Hi @mirand863, Thanks for the review. I have updated the Colab notebook with the requested changes. Please check it and let me know if it works perfectly now! ✅

mirand863 commented 5 months ago

Hi @mirand863, Thanks for the review. I have updated the Colab notebook with the requested changes. Please check it and let me know if it works perfectly now! ✅

It works now, Thanks!