search

scikit-learn-contrib / imbalanced-learn

A Python Package to Tackle the Curse of Imbalanced Datasets in Machine Learning
https://imbalanced-learn.org
MIT License
6.85k stars 1.29k forks source link

Add mypy stuff #1051

Closed elcolie closed 1 year ago

elcolie commented 1 year ago

I am running mypy and it need py.typed which is a blank file at imblearn directory.

Is your feature request related to a problem? Please describe

tao2py/internal-lift-agent/jupyter-notebook/echometer_analysis_part2/multiple_shots.py:27: error: Skipping analyzing "imblearn.combine": module is installed, but missing library stubs or py.typed marker  [import-untyped]
tao2py/internal-lift-agent/jupyter-notebook/echometer_analysis_part2/multiple_shots.py:27: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
tao2py/internal-lift-agent/jupyter-notebook/echometer_analysis_part2/multiple_shots.py:29: error: Skipping analyzing "imblearn.over_sampling": module is installed, but missing library stubs or py.typed marker  [import-untyped]
tao2py/internal-lift-agent/jupyter-notebook/echometer_analysis_part2/multiple_shots.py:32: error: Skipping analyzing "imblearn.under_sampling": module is installed, but missing library stubs or py.typed marker  [import-untyped]

Describe the solution you'd like

Build the package with py.typed in the package.

glemaitre commented 1 year ago

We are not using typing and I am not planning to make any change to use typing so I don't think that we will try to make some mypy check.