search

scikit-learn-contrib / imbalanced-learn

A Python Package to Tackle the Curse of Imbalanced Datasets in Machine Learning
https://imbalanced-learn.org
MIT License
6.85k stars 1.28k forks source link

Define inclusion criterion in imbalanced-learn in the documentation #646

Open glemaitre opened 4 years ago

glemaitre commented 4 years ago

I think that we never publicly exposed what would be the method inclusion in imbalanced-learn.

IMO, I think that we don't have to be as conservative as in scikit-learn to include new methods. However, I think that it is really important to have good documentation such that a new user can choose the appropriate method.

IMO, I think that we can include any method. However, we need to have a continuous benchmark tracking performance and computation time.

I think that the documentation should always refer to the benchmark.

@chkoar WDYT?

chkoar commented 4 years ago

I think that we never publicly exposed what would be the method inclusion in imbalanced-learn.

We did that explicitly here.

chkoar commented 4 years ago

However, we need to have a continuous benchmark tracking performance and computation time.

IMHO performance is not needed. At least for our regressions. Time is the key.

glemaitre commented 4 years ago

We did that explicitly here.

Oh I have short memory :)

chkoar commented 4 years ago

Well, that's better than having a 32bit machine in 2019!