search

scikit-learn-contrib / imbalanced-learn

A Python Package to Tackle the Curse of Imbalanced Datasets in Machine Learning
https://imbalanced-learn.org
MIT License
6.85k stars 1.29k forks source link

MAINT be more inclusive regarding dict #958

Closed glemaitre closed 1 year ago

glemaitre commented 1 year ago

dict can be too restrictive since check_sampling_strategy is returning OrderedDict.

codecov[bot] commented 1 year ago

Codecov Report

Base: 96.15% // Head: 96.15% // Increases project coverage by +0.00% :tada:

Coverage data is based on head (15592a3) compared to base (628f4a4). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #958 +/- ## ======================================= Coverage 96.15% 96.15% ======================================= Files 99 99 Lines 6892 6894 +2 Branches 994 994 ======================================= + Hits 6627 6629 +2 Misses 163 163 Partials 102 102 ``` | [Impacted Files](https://codecov.io/gh/scikit-learn-contrib/imbalanced-learn/pull/958?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scikit-learn-contrib) | Coverage Δ | | |---|---|---| | [imblearn/over\_sampling/base.py](https://codecov.io/gh/scikit-learn-contrib/imbalanced-learn/pull/958/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scikit-learn-contrib#diff-aW1ibGVhcm4vb3Zlcl9zYW1wbGluZy9iYXNlLnB5) | `100.00% <100.00%> (ø)` | | | [imblearn/under\_sampling/base.py](https://codecov.io/gh/scikit-learn-contrib/imbalanced-learn/pull/958/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scikit-learn-contrib#diff-aW1ibGVhcm4vdW5kZXJfc2FtcGxpbmcvYmFzZS5weQ==) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scikit-learn-contrib). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scikit-learn-contrib)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.