scikit-learn-contrib / lightning

Large-scale linear classification, regression and ranking in Python
https://contrib.scikit-learn.org/lightning/
1.73k stars 214 forks source link

naming consistency for step size #100

Open fabianp opened 8 years ago

fabianp commented 8 years ago

The name eta means different things depending on the classifier. On SAG classifiers it means the step size while for Fista it means the decrease factor for line-search, while on SGD this is called eta0. I propose to homogenize by setting the name of the step size to step_size on all classifiers and deprecate the other names.

mblondel commented 8 years ago

+1 on my side