[MRG] Build directly from cython sources

scikit-learn-contrib / lightning

Large-scale linear classification, regression and ranking in Python

https://contrib.scikit-learn.org/lightning/

1.73k stars 214 forks source link

[MRG] Build directly from cython sources #108

Closed lesteve closed 7 years ago

lesteve commented 7 years ago

This uses the same approach as in scikit-learn:

in development mode .cpp are built directly from cython sources
in release mode you build from .cpp files this allow to build from a released .tar.gz without cython

As part of this commit the .cpp files have been removed from the repo.

mblondel commented 7 years ago

Awesome, thanks a lot!

LGTM. @fabianp can you take a second look and merge?

fabianp commented 7 years ago

looks good to me. merging

casotto commented 7 years ago

Hello, I am a windows user that used to struggle to get a compiled version of lightning. After this change everything compiles without any problems. FYI the only difference I noticed in the compiled files is on the random_fast.cpp, the other give the same results.

Thanks a lot @lesteve ! Mattia

lesteve commented 7 years ago

Glad to hear that @casotto !