search

scikit-learn-contrib / lightning

Large-scale linear classification, regression and ranking in Python
https://contrib.scikit-learn.org/lightning/
1.73k stars 214 forks source link

CDClassifer consistency #110

Open arthurmensch opened 7 years ago

arthurmensch commented 7 years ago

The API of CDClassifier and SAG(A)Classifier should be uniformized.

For the moment, the objective of CDClassifier is parametrized by C, loss alpha and penalty, whereas SAG(A)Classifier sets C = 1 / n_samples, uses beta instead of alpha and a specific alpha to add a ridge regularization. Wouldn't it be better to align the CDClassifier API on the SAG(A)Classifier ?

fabianp commented 7 years ago

+1 from me.