search

scikit-learn-contrib / lightning

Large-scale linear classification, regression and ranking in Python
https://contrib.scikit-learn.org/lightning/
1.73k stars 214 forks source link

[MRG] Use distutils for sdist, not setuptools #123

Closed vene closed 3 years ago

vene commented 6 years ago

This fix should make sdist no longer include egg-info folder, which breaks windows builds.

fabianp commented 6 years ago

LGTM

There is a test failure on windows, but it doesn't seem related to this

aldanor commented 6 years ago

Any ideas why the test fails on windows? Could it be just @xfailed on Windows temporarily?

aldanor commented 6 years ago

Does fix the hardcoded local paths that show up in appveyor build?

vene commented 6 years ago

Yes, although a new sdist release would have to be made.

StrikerRUS commented 3 years ago

Resolved the conflict with the master branch.