search

scikit-learn-contrib / lightning

Large-scale linear classification, regression and ranking in Python
https://contrib.scikit-learn.org/lightning/
1.73k stars 214 forks source link

Recompiled with Cython 0.29.7 #133

Closed zeeraktalat closed 5 years ago

zeeraktalat commented 5 years ago

Rebuilt using Cython 0.29.7 as suggested in #132 :)

zeeraktalat commented 5 years ago

Tests failed, seemingly for a small drop in performance of classifiers.

vene commented 5 years ago

Failures are very odd. Could they be due to a change in underlying numpy/scipy/sklearn instead? Let me see if I can trigger a build on master

vene commented 5 years ago

Triggered at https://travis-ci.org/scikit-learn-contrib/lightning/builds/520280093

vene commented 5 years ago

Failures seem present identically on master. It's odd, but unrelated to this PR.

Could you modify travis.yml to test on python3.7 instead of 3.6 so we confirm that this change indeed fixes it?

zeeraktalat commented 5 years ago

3.7 fails with the same two errors but the issue with installing the package seem to be fixed. I can install using pip in a clean virtual environment.

vene commented 5 years ago

Thanks! Master should work now.