search

scikit-learn-contrib / lightning

Large-scale linear classification, regression and ranking in Python
https://contrib.scikit-learn.org/lightning/
1.73k stars 214 forks source link

Forgotten intercept in SGDRegressor #141

Closed StrikerRUS closed 3 years ago

StrikerRUS commented 4 years ago

Hey guys!

Seems that there is a bug in the predict method of SGDRegressor.

Shouldn't intercept_ be added here?

https://github.com/scikit-learn-contrib/lightning/blob/b96f9c674968496e854078163c8814049a7b9f43/lightning/impl/sgd.py#L395-L406 cf. https://github.com/scikit-learn-contrib/lightning/blob/b96f9c674968496e854078163c8814049a7b9f43/lightning/impl/base.py#L107-L111

StrikerRUS commented 4 years ago

Gently ping @mblondel @MechCoder @zermelozf @fabianp

mblondel commented 3 years ago

Yep, I think you're right. Thanks for the catch.