search

scikit-learn-contrib / lightning

Large-scale linear classification, regression and ranking in Python
https://contrib.scikit-learn.org/lightning/
1.73k stars 214 forks source link

ModuleNotFoundError: No module named 'sklearn.externals.six' #143

Closed sergeyf closed 4 years ago

sergeyf commented 4 years ago

lightning doesn't work with sklearn version 0.23:

E.g.:

    from lightning.classification import LinearSVC
  File "/opt/conda/envs/scidocs/lib/python3.7/site-packages/lightning/classification.py", line 1, in <module>
    from .impl.adagrad import AdaGradClassifier
  File "/opt/conda/envs/scidocs/lib/python3.7/site-packages/lightning/impl/adagrad.py", line 8, in <module>
    from sklearn.externals.six.moves import xrange
ModuleNotFoundError: No module named 'sklearn.externals.six'

Is there a plan to stop supporting Python 2.x?

Thanks for the great package!

StrikerRUS commented 4 years ago

Hi @sergeyf !

Seems that this package is not actively maintained any more.

You can try my PR as a hotfix: #142.

sergeyf commented 4 years ago

Thanks @StrikerRUS. I'll leave this open for others to know about.

StrikerRUS commented 4 years ago

@sergeyf Hotfix PR was merged! Now lightning should work with the latest scikit-learn.

sergeyf commented 4 years ago

Thanks a lot @StrikerRUS !