search

scikit-learn-contrib / lightning

Large-scale linear classification, regression and ranking in Python
https://contrib.scikit-learn.org/lightning/
1.73k stars 214 forks source link

explicitly require Python 3.6 and drop six dependency #170

Closed StrikerRUS closed 3 years ago

StrikerRUS commented 3 years ago

Linking https://github.com/scikit-learn-contrib/lightning/pull/142#issue-417685844

This PR should be treated as a hotfix, and ideally lightning should drop the support of Python 2 with six dependency.

and https://github.com/scikit-learn-contrib/lightning/pull/161#issuecomment-834138269

Libraries have agonized over this for a long time before py2 was sunset. Now that it has, I think it's ok and better to officially drop support.

StrikerRUS commented 3 years ago

Looks like http://contrib.scikit-learn.org/lightning/ is not in sync with the current master, e.g.

image

image

Are docs builds there triggered manually or is there any sphinx compiling error? I'm not able to see the logs (or don't know where to search for them).

StrikerRUS commented 3 years ago

@mblondel @vene Thanks for your time and consideration!

mblondel commented 3 years ago

The documentation needs to be manually updated in the gh-pages branch.

mblondel commented 3 years ago

Merged! I don't know how to automatically upload the website.