search

scikit-learn-contrib / lightning

Large-scale linear classification, regression and ranking in Python
https://contrib.scikit-learn.org/lightning/
1.73k stars 214 forks source link

FIX: add random_fast.pxd to setup.py #85

Closed fabianp closed 8 years ago

fabianp commented 8 years ago

Build is failing and its not clear why, I'm playing with it to figure it out.

fabianp commented 8 years ago

Fixed the error. Green light to merge if the build succeeds @mblondel ? (fix is trivial and doesn't add code)

fabianp commented 8 years ago

merging since I don't see any drawbacks to this trivial fix.

fabianp commented 8 years ago

@mblondel let me know if you don't agree with merging on trivial fixes or you prefer always to have +1 (although being just two I think the push responsibly on trivial fixes makes more sense)

mblondel commented 8 years ago

sure you only need my review for major changes

On Friday, 24 June 2016, Fabian Pedregosa notifications@github.com wrote:

@mblondel https://github.com/mblondel let me know if you don't agree with merging on trivial fixes or you prefer always to have +1 (although being just two I think the push responsibly on trivial fixes makes more sense)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/scikit-learn-contrib/lightning/pull/85#issuecomment-228402560, or mute the thread https://github.com/notifications/unsubscribe/AAOQ6kCvTlUFc_8zoDdB0DX9FhTd38ssks5qPA42gaJpZM4I86bu .