raise AttributeError if predict_proba is not available

scikit-learn-contrib / lightning

Large-scale linear classification, regression and ranking in Python

https://contrib.scikit-learn.org/lightning/

1.73k stars 214 forks source link

Closed kmike closed 8 years ago

kmike commented 8 years ago

In scikit-learn when predit_proba method is not available, AttributeError is raised instead of NotImplementedError. In this PR:

classifiers are changed to follow the same convention;
removed predict_log_proba mentions because lightning doesn't provide this method;
added more tests for predict_proba results.

kmike commented 8 years ago

Python 2.7 and Python 3.5 tests are failing on Travis, but failures don't look related to the PR; Python 3.4 passes on Travis.

fabianp commented 8 years ago

I've relaunched Travis, lets see what happens

kmike commented 8 years ago

weird, it now fails with the same error as https://travis-ci.org/scikit-learn-contrib/lightning/jobs/171807463, but in a different environment

fabianp commented 8 years ago

OK I fixed a bug that I introduced in my recent pull request, lets see if now tests pass

fabianp commented 8 years ago

all tests pass now :-)

fabianp commented 8 years ago

This looks good to me. I'll give @mblondel some time to give his opinion.

Thanks for your contribution!

mblondel commented 8 years ago

LGTM.

Could you also take a look at #18?

fabianp commented 8 years ago

2 LGTM = merge :-)

kmike commented 8 years ago

Thanks!

@mblondel sorry; I may take a look at it at some point in future, but not right now.

mblondel commented 8 years ago

Sure, no worries. I was just trying to motivate someone to fix a long-standing issue :b

fabianp commented 8 years ago

@mblondel : are you OK if I make a quick release ASAP?

mblondel commented 8 years ago

@fabianp Sure, thanks for doing this!