search

scikit-learn-contrib / metric-learn

Metric learning algorithms in Python
http://contrib.scikit-learn.org/metric-learn/
MIT License
1.4k stars 234 forks source link

Doesn't work with scikit-learn>=0.23.0 as logsumexp was removed from sklearn.utils.fixes. #289

Closed filaPro closed 4 years ago

filaPro commented 4 years ago

Description

Doesn't work with scikit-learn>=0.23.0 as logsumexp was removed from sklearn.utils.fixes.

Steps/Code to Reproduce

from metric_learn import NCA

Actual Results

cannot import name 'logsumexp' from 'sklearn.utils.fixes'

perimosocordiae commented 4 years ago

Looks like we're using the scikit-learn backport of logsumexp, which they removed in favor of using the official scipy version: https://github.com/scikit-learn/scikit-learn/pull/16725