search

scikit-learn-contrib / metric-learn

Metric learning algorithms in Python
http://contrib.scikit-learn.org/metric-learn/
MIT License
1.4k stars 233 forks source link

[MRG] Fix test for components_from_metric and add tests for _check_sdp_from_eigen #303

Closed wdevazelhes closed 4 years ago

wdevazelhes commented 4 years ago

Fixes #264 See https://github.com/scikit-learn-contrib/metric-learn/issues/264#issuecomment-667933419

This PR fixes the test that was failing test_components_from_metric_edge_cases, and at the same time tests better _check_sdp_from_eigen

bellet commented 4 years ago

There are just some linting errors to fix before we can merge

wdevazelhes commented 4 years ago

All CIs are green, merging

bellet commented 4 years ago

Great, thanks!