Correct FastMARS - Githubissues

scikit-learn-contrib / py-earth

A Python implementation of Jerome Friedman's Multivariate Adaptive Regression Splines

http://contrib.scikit-learn.org/py-earth/

BSD 3-Clause "New" or "Revised" License

455 stars 122 forks source link

Closed mehdidc closed 7 years ago

mehdidc commented 7 years ago

fast_k was not used
- the condition to repass through all variables was satisfied each fast_k + 1 iterations instead of fast_k iterations, so the behavior when fast_k=1 was not identical to the default behavior (not using FastMARS).

jcrudy commented 7 years ago

@mehdidc Nice catch:). Merging.