search

scikit-learn-contrib / py-earth

A Python implementation of Jerome Friedman's Multivariate Adaptive Regression Splines
http://contrib.scikit-learn.org/py-earth/
BSD 3-Clause "New" or "Revised" License
458 stars 121 forks source link

Update generated cython code using cython 0.29.13 on py3.7.4 #200

Closed lahwran closed 4 years ago

lahwran commented 5 years ago

Cython generates so much code that I'm not able to confidently audit this commit, unfortunately, but it should be about as safe to merge as previous instances of updating generated code. Ideally the generated code would be removed from the repo and generated on install, but I unfortunately don't have time to figure out how to make and debug that change right now.

jcrudy commented 5 years ago

@lahwran Thanks for this. Is this to address issue #191? Did you try the branch issue191 and find it doesn't work on your system? If not, could you please check whether it does?

I agree that the generated C code should be removed from the repo. It's nice to have dreams!

Currently, I think the main obstacle to getting this fix (or the one in branch issue191) into a release is that I have very little time to work on py-earth and am not knowledgable about conda-forge. There are also a few open bugs in v0.2dev that I want to fix before releasing it. I see two possible ways you could help move this forward if you're interested:

  1. Work on v0.2dev branch to move it toward release.

  2. Do a release 0.1.1 with just this fix in it.

If you (or anyone else reading this) want to work on either of these things, please let me know as I can guide you on what needs to be solved.