search

scikit-learn-contrib / py-earth

A Python implementation of Jerome Friedman's Multivariate Adaptive Regression Splines
http://contrib.scikit-learn.org/py-earth/
BSD 3-Clause "New" or "Revised" License
455 stars 121 forks source link

Python3.9 #228

Open MJuddBooth opened 10 months ago

MJuddBooth commented 10 months ago

Fixes #228 and continues in the line of PR #213, Including all pyx, pyd and .c files. Also fixes tests broken by numpy changes. But this is probably not compatible with older python/numpy. Created with python3.9, numpy1.25 and cython3.0

MJuddBooth commented 10 months ago

I should note that two tests (and with last push now three) fail. One appears to be precision (perhaps related to my unilateral replacement of int by int64), and another all of the elements on on the matrix lower diagonal are zero vs non-zero in the baseline, which suggests a change in dependent code, while the new one seems to be the test configuration. But I have not investigated any of these, nor do I know if the first two are introduced by my changes.