Initial pull request - Githubissues

scikit-learn-contrib / py-earth

A Python implementation of Jerome Friedman's Multivariate Adaptive Regression Splines

http://contrib.scikit-learn.org/py-earth/

BSD 3-Clause "New" or "Revised" License

457 stars 122 forks source link

Initial pull request #64

Closed aleon1138 closed 9 years ago

aleon1138 commented 9 years ago

Hi,

I'm just getting started with github and I'd like to make this small pull request to get my feet wet. I've been using your py-earth package at work and I find it very useful. Over time I'd like to contribute more to this project.

The only changes are to cleanup .gitignore, which had a bunch of duplicate line entries, and to use the dict get() method to provide a default value for missing keys.

Question: how do I run the unit tests?

Thanks,

-Arnaldo

jcrudy commented 9 years ago

Much appreciated, and welcome! I just merged your changes. I usually run unit tests by:

>nosetests -s -v .

from within the repository. There is currently one unit test that is broken in master, but it is nothing to worry about.

If you're looking to contribute more and there's any way I can facilitate, do let me know.

-Jason