Closed aleon1138 closed 9 years ago
That's awesome. I'm currently traveling without computer, but will merge as soon as I can. Probably around the 15th or so.
Sent from my iPhone
On Apr 30, 2015, at 12:00 PM, Arnaldo Leon notifications@github.com wrote:
Replaced some Cython code with numpy calls. I've achieved some significant speed improvements (20-fold). I don't think there will be any issues with parallelization later on since numpy releases the GIL (see: http://wiki.scipy.org/ParallelProgramming).
You can view, comment on, or merge this pull request online at:
https://github.com/jcrudy/py-earth/pull/75
Commit Summary
Merge pull request #1 from jcrudy/master Speed optimization in Basis.eval() File Changes
M .gitignore (1) M pyearth/_basis.pxd (12) M pyearth/_basis.pyx (147) M pyearth/earth.py (8) Patch Links:
https://github.com/jcrudy/py-earth/pull/75.patch https://github.com/jcrudy/py-earth/pull/75.diff — Reply to this email directly or view it on GitHub.
Looks good. Just merged.
Replaced some Cython code with numpy calls. I've achieved some significant speed improvements (20-fold). I don't think there will be any issues with parallelization later on since numpy releases the GIL (see: http://wiki.scipy.org/ParallelProgramming).