search

scikit-learn-contrib / scikit-learn-extra

scikit-learn contrib estimators
https://scikit-learn-extra.readthedocs.io
BSD 3-Clause "New" or "Revised" License
187 stars 42 forks source link

DOC fix broken link contributing #100

Closed TimotheeMathieu closed 3 years ago

TimotheeMathieu commented 3 years ago

typo in link to contribution file in README.

rth commented 3 years ago

Thanks! Actually maybe let's rather add it to the docs and link there?

For instance by adding it as docs/contributing.rst and adding it to the toctree at the end of index.rst with something like,

.. toctree::
   :maxdepth: 2
   :caption: Project

   contributing
TimotheeMathieu commented 3 years ago

I have some problems on the way it is rendered in docs. Working on it.

TimotheeMathieu commented 3 years ago

Ok, the problem that I saw when building doc locally does not appear in the new PR doc preview so we are good.

rth commented 3 years ago

Thanks!