scikit-learn-contrib / scikit-learn-extra

scikit-learn contrib estimators
https://scikit-learn-extra.readthedocs.io
BSD 3-Clause "New" or "Revised" License
187 stars 42 forks source link

Refactor KMedoids #140

Open chkoar opened 2 years ago

chkoar commented 2 years ago

I tried to reduce the cyclomatic complexity in k medoids. During refactoring I realized that we are testing private methods. Why is that?

So, the tests in the private methods are failing. What should we do? Make the methods public, document and test them or just remove the tests by replace them with behavior testing on public methods?

I think that tests could be improved in general.