CircleCI fails when merged into main

scikit-learn-contrib / scikit-learn-extra

scikit-learn contrib estimators

https://scikit-learn-extra.readthedocs.io

BSD 3-Clause "New" or "Revised" License

185 stars 42 forks source link

CircleCI fails when merged into main #162

Closed TimotheeMathieu closed 1 year ago

TimotheeMathieu commented 1 year ago

The check for circleci fails when merging a PR but it is green when running inside the PR. I updated circle ci to last syntax (#160 ) but this does not solve the problem. From what I see (https://discuss.circleci.com/t/git-github-com-permission-denied-publickey-on-repo-that-previously-worked/37763/4) it should be a circleci problem and some key has to be regenerated.

TimotheeMathieu commented 1 year ago

Another possibility is to just use github action which is easier to maintain, it seems kind of overkill to use circleci just for black and flake8.

rth commented 1 year ago

+1 to switch away from CircleCI for this use case. The easiest would be to enable pre-commit.ci which runs the checks in the already existing .pre-commit-config.yml. If interested let me know and I should be able to enable it.