Fix bugs in robust module and improve test coverage

scikit-learn-contrib / scikit-learn-extra

scikit-learn contrib estimators

https://scikit-learn-extra.readthedocs.io

BSD 3-Clause "New" or "Revised" License

187 stars 42 forks source link

Fix bugs in robust module and improve test coverage #78

Closed TimotheeMathieu closed 3 years ago

TimotheeMathieu commented 3 years ago

In PR #76 I succeeded in making examples faster but as a consequence some of the examples do not work anymore. It allowed me to see some bugs in the robust module and this PR is to resolve them and try to improve the test in order not to encounter this situation again.

TODO:

[x] add test for the weights_ parameter
[x] add test to compare to already existing robust algo in regression in sklearn (TheilSen, Ransac)
[x] add tests
[x] fix examples

If anyone has a test suggestion, please share in comment.

rth commented 3 years ago

Thanks @TimotheeMathieu . I'll try to review in a day or two.

rth commented 3 years ago

Please ping me once this PR is ready for a review...

TimotheeMathieu commented 3 years ago

@rth the PR is ready for review, thanks in advance. For now I removed the real data classification example as I didn't find a good example to replace the last one that had some problems.

TimotheeMathieu commented 3 years ago

I fixed the test for kmedoids here mentioned in PR #73

EDIT : I removed the test in order to make a separate PR.

TimotheeMathieu commented 3 years ago

@rth I don't understand the error in azure pipeline for python 3.9. I can't reproduce it in a virtual env so I guess it is a problem with the azure pipeline.

adrinjalali commented 3 years ago

The azure-pipelines.yaml needs fixing. The latest scipy release supports python3.9 already, shouldn't be fetching the nightly release. Not sure what's making it fetch from the nightly repo.

The scikit-learn pre-release also supports py3.9 already.