search

scikit-learn-contrib / scikit-matter

A collection of scikit-learn compatible utilities that implement methods born out of the materials science and chemistry communities
https://scikit-matter.readthedocs.io/en/v0.2.0/
BSD 3-Clause "New" or "Revised" License
70 stars 18 forks source link

Consistent validation #195

Closed rosecers closed 1 year ago

rosecers commented 1 year ago

I'm going through a lot of the estimators to run the check_estimators for scikit-learn-contrib, and am noticing the we don't validate X and y matrices consistently in every function. We should circle back on this.

agoscinski commented 1 year ago

Can this be closed with #196 ?

rosecers commented 1 year ago

Yes, I think so.