search

scikit-learn-contrib / scikit-matter

A collection of scikit-learn compatible utilities that implement methods born out of the materials science and chemistry communities
https://scikit-matter.readthedocs.io/en/v0.2.0/
BSD 3-Clause "New" or "Revised" License
70 stars 18 forks source link

Rename and add member variables #197

Closed rosecers closed 1 year ago

rosecers commented 1 year ago

As requested, the portions of #196 that only deal with renaming member variables. I tried my best to keep it as clean as possible, but it is a large change.

:books: Documentation preview :books:: https://scikit-matter--197.org.readthedocs.build/en/197/

agoscinski commented 1 year ago

Suggestion for commit message

Renaming private member variables and updating tests

* Renaming private member variables marked as private to sklearn style 
* Adding n_samples_in_, self.n_features_in_ to sklearn classes
* tests/test_feature_pcov_cur.py Adding target y to fitting for consistency
* tests/test_greedy_selector.py Removing unnecessary selector_sample fit and update error message
* tests/test_kernel_pcovr.py Adding tests  for different solvers
* tests/test_orthogonalizers.py Fix small doc typo