scikit-learn-contrib / scikit-matter

A collection of scikit-learn compatible utilities that implement methods born out of the materials science and chemistry communities
https://scikit-matter.readthedocs.io/en/v0.2.0/
BSD 3-Clause "New" or "Revised" License
76 stars 20 forks source link

Making the trace component of SparseKernelNormalizer more memory-frie… #219

Open rosecers opened 10 months ago

rosecers commented 10 months ago

…ndly

Using the equality of traces under cyclic products, I've modified the sparse kernel normalizer to be less memory-hungry. Had a few issues using this and having RAM crash

Contributor (creator of PR) checklist

For Reviewer


:books: Documentation preview :books:: https://scikit-matter--219.org.readthedocs.build/en/219/

PicoCentauri commented 7 months ago

What is the status here?

Seems like we have to fix some assertions in the test_sparse_kernel_centerer.py